Skip to content

[5.4] Add publishing checks to banner item retrieval #46881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muhme merged 9 commits into from
Feb 21, 2026
+21 −2
Merged

[5.4] Add publishing checks to banner item retrieval #46881

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9821a5e
Fix click tracking for unpublished or expired banners in com_banners
nielsnuebel Feb 12, 2026
fa5a774
Refactor banner query by removing extendWhere
nielsnuebel Feb 12, 2026
7184add
Apply suggestion from @HLeithner
nielsnuebel Feb 13, 2026
ae7a17b
Apply suggestion from @HLeithner
nielsnuebel Feb 13, 2026
6333a49
Apply suggestion from @HLeithner
nielsnuebel Feb 13, 2026
5f87833
Fix variable scope for nowDate in lambda function
nielsnuebel Feb 13, 2026
7fa4a61
Fix formatting of database variable assignment
nielsnuebel Feb 13, 2026
0fd57ff
BannerModel.php aktualisieren
nielsnuebel Feb 13, 2026
fa9b524
Merge branch '5.4-dev' into nielsnuebel-patch-46880
muhme Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion components/com_banners/src/Model/BannerModel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ public function &getItem()
$db = $this->getDatabase();

$loader = function ($id) use ($db) {
$nowDate = Factory::getDate()->toSql();
$query = $db->getQuery(true);

$query->select(
Expand All @@ -184,7 +185,25 @@ public function &getItem()
->from($db->quoteName('#__banners', 'a'))
->join('LEFT', $db->quoteName('#__banner_clients', 'cl'), $db->quoteName('cl.id') . ' = ' . $db->quoteName('a.cid'))
->where($db->quoteName('a.id') . ' = :id')
->bind(':id', $id, ParameterType::INTEGER);
->where($db->quoteName('a.state') . ' = 1')
->extendWhere(
'AND',
[
$db->quoteName('a.publish_up') . ' IS NULL',
$db->quoteName('a.publish_up') . ' <= :nowDate',
],
'OR'
)
->extendWhere(
'AND',
[
$db->quoteName('a.publish_down') . ' IS NULL',
$db->quoteName('a.publish_down') . ' >= :nowDate',
],
'OR'
)
->bind(':id', $id, ParameterType::INTEGER)
->bind(':nowDate', $nowDate);

$db->setQuery($query);

Expand Down
Loading