[6.1] {loadmoduleid} include title#46902
Open
brianteeman wants to merge 1 commit intojoomla:6.1-devfrom
Open
Conversation
When you use the editor-xtd button to insert a module in an article you get the chance to select the module by title in the modal but as soon as it is inserted into the article it only displays the module id This is a problem because when you go back to edit the article you cannot easily determine which module is being inserted. The only way to do that is to quit the article go to the module manager and find the module by id number. This PR changes that to additionally insert the module title.
|
I have tested this item ✅ successfully on 746421e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46902. |
1 similar comment
|
I have tested this item ✅ successfully on 746421e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46902. |
Fedik
reviewed
Feb 17, 2026
|
|
||
| $attrs1 = $attrs; | ||
| $attrs1 .= ' data-html="{loadmoduleid ' . ((int) $item->id) . '}"'; | ||
| $attrs1 .= ' data-html="{loadmoduleid ' . ((int) $item->id) . ' - ' . $this->escape($item->title) . '}"'; |
Member
There was a problem hiding this comment.
I think it is better to keep the same "format" as it is for loadmodule:
{loadmodule mod_examplem,Example title}
I mean comma separated.
Contributor
Author
There was a problem hiding this comment.
This is for visual display only so i would not like to change it
|
I have tested this item ✅ successfully on 746421e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46902. |
|
I have tested this item ✅ successfully on 746421e Thanks @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46902. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46902. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARTIAL Pull Request for Issue #46900 .
Summary of Changes
When you use the editor-xtd button to insert a module in an article you get the chance to select the module by title in the modal but as soon as it is inserted into the article it only displays the module id
This is a problem because when you go back to edit the article you cannot easily determine which module is being inserted. The only way to do that is to quit the article go to the module manager and find the module by id number.
This PR changes that to additionally insert the module title. This is a cosmetic change and doesnt impact existing modules that have been inserted.
Testing Instructions
Insert a module into an article and confirm that it is displayed as expected in the front end
Actual result BEFORE applying this Pull Request
{loadmoduleid 99}
where 99 is the id of the module
Expected result AFTER applying this Pull Request
{loadmoduleid 99 - Latest Posts}
where 99 is the id of the module AND Latest Posts is the title of the module
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed