[6.1] Rename and improve update SQL scripts for the 6.1.0 what's new guided tour#47389
Merged
tecpromotion merged 2 commits intojoomla:6.1-devfrom Mar 14, 2026
Merged
Conversation
5 tasks
Contributor
|
Thanks @richard67 will it also need a change in the list of removed files? |
Member
Author
@brianteeman In this case here no, as the "6.1.0-2026-02-25.sql" haven't been released yet. If they had been in beta2, it would need that. |
Contributor
|
I have tested this item ✅ successfully on 4aa265d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47389. |
Contributor
|
Thanks @brianteeman for testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for #47229 (comment) .
Summary of Changes
This pull request (PR) renames the update SQL script which were added with PR #47229 so that they have a newer schema version in their name than the highest schema version of currently present update SQL scripts at the time of the merge of that PR.
In addition it modifies the insert statement for the tour record so it does not produce duplicates when running multiple times, e.g. after a failed previous update attempt. The same has been made for the 6.0.0 what's new tour, see #45967 .
Finally it makes some small code style change for better readability.
Testing Instructions
Code review should be sufficient, e.g. compare with #45967 , and in addition check the new file names.
Actual result BEFORE applying this Pull Request
The update SQL script "6.1.0-2026-02-25.sql" is not executed when updating a 6.1 nightly build from before last night to the latest 6.1 nightly build using the upload & update method because the schema version in the file name of that script is older than the current database schema version.
When executing the update SQL script more than one time, you have duplicate tour and tour step records.
Expected result AFTER applying this Pull Request
The update SQL script "6.1.0-2026-03-13.sql" is executed when updating a 6.1 nightly build from before last night to the latest 6.1 nightly build using the upload & update method because the schema version in the file name of that script is newer than the current database schema version.
When executing the update SQL script more than one time, you only have duplicate tour step records (which cannot be easily avoided) but no duplicate tour record.
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed