Skip to content

Conversation

@github-actions
Copy link

Closes #712

Overrides the save method to clear the system cache after a successful save operation.
@github-actions github-actions bot added this to the v6.0.3 milestone Nov 11, 2025
@github-actions github-actions bot added the bug label Nov 11, 2025
@jebbdomingo jebbdomingo requested a review from amazeika November 11, 2025 03:45

if ($result) {
// Clear the system cache
JFactory::getCache('_system', 'output')->clean();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amazeika Existing extension's configs are saving thru the extension entity hence hooking up here after save.
We could go for model behavior but the only command callback we could hook into after saving is _afterReset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jebbdomingo You can just rename it ComKoowaModelEntityConfig ... then extend from it. Please add a ticket on each extension repos so that we make this change as well. This should do the trick nicely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just rename it ComKoowaModelEntityConfig

@amazeika That would mean renaming the extensions model as well. While keeping it as is will not need to change the other extensions other than removing its own clearing of the system cache.
e.g. https://github.com/joomlatools/docman/blob/d11049a036fabd70512a450e46186359a14924c0/code/administrator/components/com_docman/model/entity/config.php#L193-L197

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jebbdomingo ok, yes. I didn't see the link with the config entity. This is saving the parameters on the extensions table and all of the components use it already. It's good then.

@amazeika amazeika merged commit d6123d3 into master Nov 14, 2025
1 check passed
@amazeika amazeika deleted the feature/712-cache-management branch November 14, 2025 10:01
@amazeika
Copy link
Member

@jebbdomingo one last comment. Are those calls Joomla 3, 4, 5 and 6 compatible?

@jebbdomingo
Copy link
Member

@jebbdomingo one last comment. Are those calls Joomla 3, 4, 5 and 6 compatible?

@amazeika I tested til Joomla 5. I will test in Joomla 6

@jebbdomingo
Copy link
Member

@jebbdomingo one last comment. Are those calls Joomla 3, 4, 5 and 6 compatible?

@amazeika I tested til Joomla 5. I will test in Joomla 6

@amazeika aplogies, I wasn't able to test in Joomla 3 as the installer of latest DOCman failed to install in Joomla 3. However, I tested in Joomla 4, 5 and 6 and all worked as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extensions settings and Joomla's cache

3 participants