MLX: fix mx.array removal + respect model hidden_size in fallback; ad… #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
joonsoome
commented
Oct 24, 2025
joonsoome
commented
- Add _mx_array helper to handle MLX API change (mx.array → mx.asarray/mx.numpy.array)
- Replace all mx.array calls with compatibility helper (embedding, similarity, placeholder)
- Use config.get('hidden_size', 4096) in placeholder path to avoid forced 4096D
- Update README with MLX compatibility notes and quick validation snippet
…d README compatibility note
- Add _mx_array helper to handle MLX API change (mx.array → mx.asarray/mx.numpy.array)
- Replace all mx.array calls with compatibility helper (embedding, similarity, placeholder)
- Use config.get('hidden_size', 4096) in placeholder path to avoid forced 4096D
- Update README with MLX compatibility notes and quick validation snippet
added 3 commits
October 24, 2025 20:49
- Wrap long lines in app/main.py; split complex f-strings - Strip trailing whitespace in router/tests; minor whitespace tidy in models - Align with CI code quality gate (black --check --line-length 120)
- Keep black/isort/flake8 visibility but avoid red X on formatting drift - Renames step to clarify non-blocking nature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.