Skip to content

Conversation

@Hephaest
Copy link

@Hephaest Hephaest commented Nov 30, 2025

Background

I have been using Ice for a couple of months, and I love it. The only thing that made me feel uncomfortable was the issue that was frequently mentioned in the community – menu bar clipping, which always floated on my external monitor when I turn my laptop's window full screen.

Since it's still not fixed yet, I would like to help and do a hotfix.

Notes

  • I'm not an iOS developer (I have little knowledge but not much), so I ask AI for help.
  • I have done self-testing on my laptop and tried to fix this with minimal risk impact.
  • I have left useful comments on the code change so that it could help the team better understand why this fix matters.

Related Issues

return
}

// Validate before showing to ensure panel should be visible on this screen.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures the panel is validated before being shown. If it is in full-screen mode, it should be hidden.

Copy link
Author

@Hephaest Hephaest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain the necessity of the fixes.

@Hephaest Hephaest marked this pull request as ready for review November 30, 2025 20:29
@Hephaest Hephaest marked this pull request as draft November 30, 2025 20:33
@Hephaest
Copy link
Author

Hi Jordan @jordanbaird

Feel free to review my PR and make any adjustments to align it with your best coding practices. Hope this fix could be helpful for the community :)

@Hephaest Hephaest marked this pull request as ready for review November 30, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant