Add option to disable right-click menu bar overlay#893
Open
rafaelreverberi wants to merge 1 commit into
Open
Conversation
rafaelreverberi
commented
Mar 3, 2026
rafaelreverberi
commented
- Add Advanced setting to disable Ice's right-click menu bar menu
- When enabled, right-click no longer shows 'Edit Menu Bar Appearance' and 'Ice Settings'
- Keep access via ⌥⌘-click as an alternative entry point
- Improves compatibility with apps like DynamicLake
- Add Advanced setting to disable Ice's right-click menu bar menu - When enabled, right-click no longer shows 'Edit Menu Bar Appearance' and 'Ice Settings' - Keep access via ⌥⌘-click as an alternative entry point - Improves compatibility with apps like DynamicLake
1 task
davidrudduck
added a commit
to davidrudduck/Ice
that referenced
this pull request
Apr 23, 2026
Adapted from upstream PR jordanbaird#893 by rafaelreverberi. - Disabling 'Enable secondary context menu' suppresses Ice right-click menus - Adds Option+Command+click fallback to open Ice settings when disabled - Improves compatibility with apps like DynamicLake - Applied to HIDEventManager.swift and updated settings API for macos-26
davidrudduck
added a commit
to davidrudduck/Ice
that referenced
this pull request
Apr 23, 2026
Resolved during build verification: HIDEventManager.swift (PR jordanbaird#893, jordanbaird#900): - Use NSApplication.shared.sendAction to open settings (AppState has no appDelegate) - Add .map + .removeDuplicates() to CombineLatest4 to prevent startAll/stopAll stack imbalance on repeated setting changes (reviewer finding: HIGH) - Call handlePreventShowOnHover before early return in fallback to avoid skipping hover suppression on settings-open click (reviewer finding: HIGH) ControlItem.swift (PR jordanbaird#893): - Move enableSecondaryContextMenu read inside Task body to avoid stale capture (reviewer finding: MEDIUM) - Read setting directly for synchronous rightMouseUp guard MenuBarOverlayPanel.swift (PR jordanbaird#803): - Replace removed WindowInfo.getOnScreenWindows() with createWindows(option:) - Fix validate() guard: returns Bool, not Optional (was always true) MenuBarItemImageCache.swift (PR jordanbaird#804): - Replace removed itemCache.allItems with itemCache.managedItems - Replace .info key with .tag key to match [MenuBarItemTag: CapturedImage] dict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.