add Chinese support#948
Open
Antenbabby wants to merge 13 commits into
Open
Conversation
Clicking the HItem (hidden section divider) now shows an IceBarPanel anchored below HItem instead of expanding items inline in the menu bar. The popup displays only stowed icons and supports click-to-interact via the existing tempShowItem mechanism. Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
Triggered on push to main and claude/* branches. Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
Uploads the compiled Ice.app as a downloadable artifact. Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
Use find to locate .app in DerivedData, then package with ditto. This ensures the .app bundle is packaged correctly regardless of the exact DerivedData layout. Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
upload-artifact@v4 zips directory contents, not the directory itself, which breaks .app bundles. Now using ditto to create a proper zip and uploading that instead. Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
- Add ad-hoc code signing to CI build so macOS properly processes Accessibility permission requests - Fix Accessibility permission settingsURL to navigate users to the correct System Settings pane (was nil before) Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
New infrastructure: - Ice/Localization/AppLanguage.swift — language enum with auto-detect - Ice/Localization/LocalizationManager.swift — ObservableObject manager - Ice/Localization/LocalizationKey.swift — string table with Chinese translations Localized files: - All settings panes (General, Advanced, About, Hotkeys, Layout, Appearance) - SettingsView sidebar and navigation - NSMenu items (ControlItem right-click, MenuBarManager) - Enum display strings (RehideStrategy, IceBarLocation, MenuBarTintKind, MenuBarSection.Name, SystemAppearance) Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
- Fix duplicate raw value "Menu Bar Appearance" in LocalizationKey - Wrap annotation strings with LocalizedStringKey for type compatibility Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
- Fix LocalizedStringKey type mismatches in all settings panes - Add appState/loc to PreviewButton struct - Fix extra/missing parentheses in annotation calls Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
- Make toggleSectionDividers and settingsMenuBarAppearance raw values unique - Fix AboutSettingsPane string type mismatch - Fix GeneralSettingsPane annotation paren placement Co-Authored-By: Claude Haiku 4.5 (1M context) <noreply@anthropic.com>
Add language switching (English/Chinese) and CI build workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add Chinese support
添加中文支持