Skip to content

fix(ci): move docker publish into release-please workflow#15

Merged
jordangarrison merged 2 commits intomainfrom
fix-release-tagging
Mar 7, 2026
Merged

fix(ci): move docker publish into release-please workflow#15
jordangarrison merged 2 commits intomainfrom
fix-release-tagging

Conversation

@jordangarrison
Copy link
Copy Markdown
Owner

Summary

  • Move Docker image build & push into the release-please.yml workflow as a dependent publish job that runs when release_created is true
  • Use tag_name output from release-please to version-tag the Docker image (e.g. v0.3.0)
  • Convert publish.yml from release: [published] trigger (which never fires due to GITHUB_TOKEN limitations) to workflow_dispatch for manual re-publishing

Root Cause

When release-please creates a GitHub release using the default GITHUB_TOKEN, the resulting release: [published] event does not trigger other workflows. This is a GitHub security feature to prevent infinite workflow loops. The publish.yml workflow was never running.

Test Plan

  • Merge a release-please PR and verify the publish job runs in the Release Please workflow
  • Verify the Docker image is pushed to GHCR with both latest and version tags
  • Verify the Publish Release workflow can be manually triggered via workflow_dispatch

Runs `mix setup` automatically on first shell entry per worktree,
gated by a `_build/.setup_done` marker file. Skips on subsequent entries.
The publish.yml workflow triggered on `release: [published]` never
fired because releases created by the default GITHUB_TOKEN do not
propagate events to other workflows (GitHub security feature).

Move the Docker build & push into the release-please workflow as a
dependent job that runs when `release_created` is true, using the
`tag_name` output for the image version tag.

Convert publish.yml to a workflow_dispatch fallback for manual
re-publishing of a specific release tag.
@jordangarrison jordangarrison merged commit 5634121 into main Mar 7, 2026
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 7, 2026
jordangarrison pushed a commit that referenced this pull request Mar 7, 2026
🚀 Merging this PR will create a new release
---


##
[0.3.0](v0.2.0...v0.3.0)
(2026-03-07)


### Features

* add paginated full views for user PRs and commits
([#13](#13))
([2377eca](2377eca))


### Bug Fixes

* **ci:** move docker publish into release-please workflow
([#15](#15))
([5634121](5634121))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant