feat: migrate to visill 0.1.0-rc#8
Open
jordanl17 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Long-lived migration PR for the visill framework rollout. Tracks the floating
@rcdist-tag through the rollout window and merges tomainonly at visill stable cut (0.1.0on@latest) per ADR 0020.What changed
finalizeBundlefunction and adoptsimport { finalizeBundle } from '@visill/build'with explicit{ outDir: assetsDir }. TF retains manual plugin composition (viteSingleFile+finalizeBundle) rather thandefineVisillConfig({})because TF's skill artefacts live undertargetable-feedback/directly (noskill-src/source, noassembleSkillflow).requireElementandownDescendanthelpers with@visill/sdkimports. AllownDescendantcall sites now pass'.unit'as the boundary selector (third arg, added in@visill/sdk@0.1.0-rc.2to support TF's nested.unit > .guidance-wrap > .targetpattern). Negated guards rewritten to positive form per the visill conventions.pnpm.overrideslink the three@visill/*packages to sibling source paths so SDK edits propagate without republish..npmrc.ci+jq 'del(.pnpm)'strips the overrides block so CI installs the published RC.scripts/parity-check.shimplements the five parity gates from PRD 007 §6. Gate 1 was extended to treatrender.pyas optional, since TF has no Mustache-rendered skill artefacts. Wired into.github/workflows/build.yml.engines.nodebumped to>=24.0.0,@types/nodeto^24.0.0, workflownode-versionto'24', matching the visill workspace baseline.Parity gates (local smoke vs prior main)
Do not merge yet
This PR is intentionally open through Phase 10. At stable cut: bump
"rc"pins to^0.1.0, droppnpm.overrides, and merge.