go.mod: bump x/tools to v0.30.0 for Go 1.24 support#25
Merged
yuzefovich merged 1 commit intojordanlewis:masterfrom Mar 13, 2026
Merged
go.mod: bump x/tools to v0.30.0 for Go 1.24 support#25yuzefovich merged 1 commit intojordanlewis:masterfrom
yuzefovich merged 1 commit intojordanlewis:masterfrom
Conversation
x/tools v0.17.0 can't parse Go 1.24's new package export format, causing gcassert to fail with errors like: internal error: package "fmt" without types was imported from "..." Bump to v0.30.0 which supports Go 1.24. This raises the minimum Go version to 1.22. Also update CI: bump Go from 1.18 to 1.22/1.23/1.24 matrix, and update actions/checkout to v4 and actions/setup-go to v5. Fixes jordanlewis#24. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yuzefovich
approved these changes
Mar 13, 2026
mw5h
added a commit
to mw5h/apd
that referenced
this pull request
Mar 13, 2026
Update gcassert pin to ad3fae17aff which includes the x/tools bump to v0.30.0 (jordanlewis/gcassert#25), fixing Go 1.24 support. Remove the Go < 1.24 cap that was added as a workaround in cockroachdb#146. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/toolsfrom v0.17.0 to v0.30.0x/tools v0.17.0can't parse Go 1.24's new package export format, causing gcassert to fail:This is blocking CI for projects like cockroachdb/apd and will also affect cockroachdb/cockroach (which uses Go 1.25).
Verified that gcassert builds, tests pass, and works correctly against
cockroachdb/apdwith this change.Fixes #24.
🤖 Generated with Claude Code