Open
Conversation
jordansissel
requested changes
Mar 5, 2023
Owner
jordansissel
left a comment
jordansissel
left a comment
There was a problem hiding this comment.
I did a quick scan and found one issue the spell checker created. I'll need to do a more thorough read later.
lib/fpm/package/gem.rb
Outdated
| P_RE_SEPARATOR = '\s[-=/(]?\s?' | ||
| P_RE_DATE1 = '\d{4}-\d{2}-\d{2}' | ||
| P_RE_DATE2 = '\w+ \d{1,2}(?:st|nd|rd|th)?,\s\d{4}' | ||
| P_RE_DATE2 = '\w+ \d{1,2}(?:st|and|rd|th)?,\s\d{4}' |
Owner
There was a problem hiding this comment.
Spell checker didn't seem to know that this is a regular expression and that 'nd' is correct here as the pattern intends to match things like '1st' or '23rd' or '42nd'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via
codespell -S templates -L claus,nd