feat(ci): Bump checkout to v4; Add new Ruby to CI test#2086
Open
xlionjuan wants to merge 2 commits intojordansissel:mainfrom
Open
feat(ci): Bump checkout to v4; Add new Ruby to CI test#2086xlionjuan wants to merge 2 commits intojordansissel:mainfrom
xlionjuan wants to merge 2 commits intojordansissel:mainfrom
Conversation
Owner
|
Hello! Thank you for improving fpm :) I am in favor of adding additional ruby versions to test against. However, I am not in favor of removing older versions of ruby. I'd like to keep testing against older versions of ruby. This is because while the Ruby project may have moved on from Ruby 2.x and even Ruby 1.9.x, there's still a wide world of systems using these older and abandoned versions of ruby, and I think it is useful to continue testing against these versions. I don't want to accidentally break fpm on older versions of ruby :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.ruby-lang.org/en/downloads/branches/