Filter newer style bash functions out of shell script template's .ins…#2116
Merged
jordansissel merged 1 commit intojordansissel:mainfrom Nov 14, 2025
Merged
Conversation
…tall-metadata file.
This was referenced Oct 30, 2025
Owner
|
Code looks ok! I haven't tested, but researching what bash does to export functions shows that this PR looks right. I tried to find a way to have bash simply unexport all functions, but getting a list of just the exported function names seems difficult to do more easily than you have shown, and as it fits with the existing grep pipeline, this seems ok:) For posterity, best I could come up with was this one, to unexport any exported functions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tall-metadata file.
Exported bash functions take the format of
BASH_FUNC_function_name%%. Including them in the .install-metadata file causes export errors, so update the filtering logic to account for them.