Update to use new metacpan search syntax - #2144
Merged
Merged
Conversation
Context: A few months ago, metacpan's API had some slight changes due to an upgrade to their Elasticsearch cluster. Fixes #2143
Owner
Author
|
Thanks to @NicholasBHubbard's work on #2122, it's very nice seeing the test suite do something useful! :) Some local testing still fails for me (things not covered by the test suite). I'll fix those and add tests before merging. |
jordansissel
force-pushed
the
issue/2143
branch
from
March 16, 2026 17:02
063aa96 to
3df6379
Compare
The line was calling search(dep_name) and not using the result; the side
effect is for things like Regexp::Common, a dependency is Config, and
'search("Config")' was causing a 404 because search() queries the module
search api, and Config doesn't appear to be a module on cpan or is a
distribution? It's been a while since I've used perl and these brain
cells do not recall this ;P
Tests: Add test case for packaging Regexp::Common
This module lists dependencies on things which seem to come with perl,
so it's a good test case for something not currently exercised by the
suite.
jordansissel
force-pushed
the
issue/2143
branch
from
March 16, 2026 17:26
3df6379 to
7d3c758
Compare
Contributor
|
@jordansissel thanks for pushing this forward! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: A few months ago, metacpan's API had some slight changes due to an upgrade to their Elasticsearch cluster.
Fixes #2143