Open
Conversation
Ruby 2.x are end of life. Latest mustache 1.1.1 looks to be working just fine in my superficial teseting on Ubuntu 22.04
Merged
Owner
|
While Ruby 2.x is EOL there are still many places using it, and my general approach has been to attempt backwards compatibility where possible and not to abandon old things simply because they are old or deprecated. I’m on my phone typing this and not able to text Ruby 2.x vs 3.x for various mustache versions, nor experimenting with things like removing mustache. I’m open to this change but not yet at the expense of losing Ruby 2.x support. I welcome your thoughts on this :) |
Author
|
It's not a big issue for me. There will always be custom patches that I will need to maintain internally anyway. So, I'm happy to keep using a patched version with this patch applied manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ruby 2.x are end of life.
Latest mustache 1.1.1 looks to be working just fine in my superficial
teseting on Ubuntu 22.04