Zipped filewatching #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 27, 2014 11:14
Initially, I started refactoring everything but as this isn't my gem I ended up simply inheriting FileWatch::Tail as to maintain backwards compatibility as much as possible. Unfortunately, if Tail ever changes, Gzip will need to be retested.
|
Howdy! Thanks for your effort on this. It might be helpful to know the future roadmap a bit for logstash to see how this all fits together. In logstash 1.2.0 we added the
This would allow filewatch to do what it is good at (stream file data) and a separate, small 'gzip' codec worry about decompression. With that said, I think this patch is a step away from the codec system, not towards it. |
|
Ok, that all sounds fine and dandy. Feel free to close this pull request then if you think it's a step backwards. I can just use it locally until Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a filewatch for gzipped text files. Necessary to implement the file_gz logstash plugin that I'm working on. Seems to be working well for me so far. Thought you may want it as part of the gem.