fix: Missing percentage precision for window size (#488)#494
Open
dengbo11 wants to merge 1 commit intojordansissel:masterfrom
Open
fix: Missing percentage precision for window size (#488)#494dengbo11 wants to merge 1 commit intojordansissel:masterfrom
dengbo11 wants to merge 1 commit intojordansissel:masterfrom
Conversation
Use strtod() instead of strtoul() for percentage parsing, and the window size should be calculated using a percentage value if a percentage is specified. other changes: Fix argument count validation error message. Fixes jordansissel#488
dengbo11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Missing percentage precision for window size(#488)
Use strtod() instead of strtoul() for percentage parsing, and the window size should be calculated using a percentage value if a percentage
is specified.
other changes:
Fix argument count validation error message.
Fixes #488