fix: reacquire wake lock check after release #280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
@calebchiam Some tests are failing, can you have a look? |
Contributor
Author
|
@jorisre thanks for the quick review, dropped the old test, which is no longer relevant testing it further, will ping in a bit |
Contributor
Author
|
@jorisre fixed the deeper issue of this not calling |
jorisre
approved these changes
Apr 15, 2025
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Follow-up to #279.
#279 (comment)
Approach
Check that
wakeLock.current === nullbefore attempting to reacquire the lock.Instead of using the vanilla
await navigator.wakeLock.request('screen'), use the already-definedrequest()method to reacquire the lock. This ensures the release state and onRelease handlers are updated/called properly.