convert uploaded images and append images on edit #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ change logic for adding new images, not replacing old according field_index
update readme
|
Hi, looks like a nice addition! |
|
Hello.
Codesniffer i will fix. Test i cant make, i dont know how to write them )
Abot forceConvert, i have opinion what it can be doing via presets with
name default, what do you think?
With best regards, Oleg.
чт, 16 авг. 2018 г., 11:23 Jasper Smet <[email protected]>:
… Hi, looks like a nice addition!
Could you fix the codesniffer issues and maybe add some tests for the
parts you added?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABleNQyU81gAOvQBNq6TpQKaPOj1LCiZks5uRSv_gaJpZM4V-yZU>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convert uploaded images and append images on edit