Skip to content

Conversation

@zaro
Copy link
Contributor

@zaro zaro commented Jan 13, 2025

This approach is parsing the body of the Github releases for JetBrainsRuntime, which contains a easily parsable markdown table.

Fixes #41

Copy link
Owner

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaro Thanks for your contribution! ❤️

@joschi joschi added the enhancement New feature or request label Jan 13, 2025
@joschi joschi merged commit 7f1e7b1 into joschi:main Jan 13, 2025
1 check passed
joschi added a commit that referenced this pull request Jan 14, 2025
@joschi
Copy link
Owner

joschi commented Jan 14, 2025

@zaro Unfortunately I had to revert this change because the JetBrains provider seems to be hanging for unknown reasons:

https://github.com/joschi/java-metadata/actions/runs/12759006080/job/35562033821

Maybe you can take a look at some other time.

@zaro
Copy link
Contributor Author

zaro commented Jan 15, 2025

@joschi Sure, will take a look and try to fix.

@zaro
Copy link
Contributor Author

zaro commented Jan 15, 2025

IMO there is nothing wrong with the script , it's simply the number of files that need to be downloaded and processed. I must admit that during my local testing I limited the number of releases processed, because the full run will take many hours on my internet connection.

Now here are the details:
Currently the script, downloads the last 100 Github releases , which while not that much means around 6500 packages to download and checksum. My hope was that the Github runner will be able to handle that in sane amount of time, but apparently it can't.

I see two ways around that:

  • Limit the number of Github releases processed, to something like 10. Github runner should be able to handle that. The downside is that earlier versions will be unavailable.
  • Include the output of the first run in the PR, this means that only new releases will be download in the Github action and everything should work normally.

@joschi What do you think? Which one is preferable ?

@joschi
Copy link
Owner

joschi commented Jan 16, 2025

Include the output of the first run in the PR, this means that only new releases will be download in the Github action and everything should work normally.

I think this would be preferable, if you can spend the time running the initial download.

@joschi
Copy link
Owner

joschi commented Jan 16, 2025

@zaro It also looks like the architecture, OS, Java version, and version attributes are not properly detected as well as the file type.

Example:

{
  "vendor": "jetbrains",
  "filename": "jbr-11_0_16-linux-aarch64-b2043.64.tar.gz",
  "release_type": "ga",
  "version": "",
  "java_version": "",
  "jvm_impl": "hotspot",
  "os": "unknown-os-",
  "architecture": "unknown-architecture-",
  "file_type": null,
  "image_type": "jre",
  "features": [],
  "url": "https://cache-redirector.jetbrains.com/intellij-jbr/jbr-11_0_16-linux-aarch64-b2043.64.tar.gz",
  "md5": "c79c2fddb3869f1cba0ff370dcd1b615",
  "md5_file": "jbr-11_0_16-linux-aarch64-b2043.64.tar.gz.md5",
  "sha1": "cbd0602f34712af23a409c8ad087a88102490397",
  "sha1_file": "jbr-11_0_16-linux-aarch64-b2043.64.tar.gz.sha1",
  "sha256": "adc83f8d05880effc2673a2d32ff3e8c57de13f705b479ba012a72f3facba405",
  "sha256_file": "jbr-11_0_16-linux-aarch64-b2043.64.tar.gz.sha256",
  "sha512": "1ee23114ba89bf398345585462fd9507344a7f87aa3a410f0d9afb477f4030bfe1903bbb9601c2f067a8b71a3253382f60cb4327b70c31f3cdd2055cce7f7a70",
  "sha512_file": "jbr-11_0_16-linux-aarch64-b2043.64.tar.gz.sha512",
  "size": 68127869
}

You can run your script locally via bin/jetbrains.bash docs/metadata/ docs/checksums/.

@joschi joschi mentioned this pull request Jan 17, 2025
joschi pushed a commit that referenced this pull request Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FEAT: Add Jetbrains Java

2 participants