Skip to content

Conversation

@sh41
Copy link
Contributor

@sh41 sh41 commented Sep 15, 2025

closes #81

Copy link
Owner

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sh41 Thanks for your contribution!

It would be great if we could separate cleaning up the old data and the actual code change in this PR. 😄

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdoptOpenJDK went to become Eclipse Temurin, so maybe we also have to update bin/temurin.bash.

https://github.com/joschi/java-metadata/blob/c114d45e9866605f0c660045826c7ba495829499/bin/temurin.bash

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I've implemented the same changes in that script.

@sh41
Copy link
Contributor Author

sh41 commented Sep 16, 2025

@sh41 Thanks for your contribution!

It would be great if we could separate cleaning up the old data and the actual code change in this PR. 😄

I've reverted the clean up so this PR is now only the script changes for AdoptOpenJDK & Temurin.

Copy link
Owner

@joschi joschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sh41 Thanks for your contribution! ❤️

@joschi joschi merged commit 54a5102 into joschi:main Sep 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disambiguate OpenJDK musl & glibc

2 participants