Add support for object arrays with separate text and value

[ahmed-saber]

• Add support for object arrays with separate text and value properties
• Enable search functionality within both text and value fields
• Maintain full backward compatibility with existing string arrays
• Add helper functions: getOptionText(), getOptionValue(), getSearchableContent()
• Update filtering logic to handle both string and object formats
• Create comprehensive example (28_autocomplete_text_value_objects.html)
• Bump version to 10.3.0

[josdejong]

Thanks Ahmed for this PR, I'll look into it next week.

[ahmed-saber]

@josdejong I hope you can merge it soon, as I'm working on a feature that depends on these changes. Please remember to update the TypeScript for the library as well

[josdejong]

I expect to be able to look into it coming Thursday or Friday.

Updating the types will require a separate PR at DefinitelyTyped I think.

[josdejong]

Thanks for your PR @ahmed-saber . It looks well taken care of!

I made a couple of inline comments, can you have a look at those?

Also, just as a reminder: we'll need to update the type definitions in definitelytyped/types/jsoneditor after this PR is merged and published.

[josdejong]

Thanks for all the updates, I think the PR is almost ready to be finished. Can you have a look at the new inline comments?

[josdejong]

Thanks for your latest updates Ahmed. Here a few more comments.

[josdejong]

Thanks for the updates @ahmed-saber!

I tested the examples again, there is one odd issue: in example 28_autocomplete_text_value_objects.html, I see the config filter: 'contain', so I would expect to be able to enter something halfway the value/text of an option. When I enter "h" I get two options "Alphabet Inc. (Google)" and "PayPal Holdings Inc.", as expected. But when I enter a second letter "ho" from "holdings", there are no autocompletion options whereas I would expect one match: "PayPal Holdings Inc.". I also cannot search text halfway a value, like entering "ZN" from "AMZN" - no hits. Any idea?

[josdejong]

Similarly, in example 29_autocomplete_multiple_fields.html, when I enter "ber" I get two options "Germany" and "Australia" as expected, but when I keep typing and make it "berlin", I get zero autocomplete options wheras I still would expect "Germany".

[ahmed-saber]

I found the line was causing if (rows.length < 2) return The autocomplete with filter: 'contain' should now work exactly as expected.

[josdejong]

Ah, now I understand what's going on: when the token matches halfway a value, the hintText cannot autocomplete the "rest" of the value because we're not at the start. Showing the dropdown in case of a single match too (rows.length < 2) makes sense 👍.

I think we can merge the PR now, thanks for all your work!

[josdejong]

Published now in v10.3.0 🎉

[ahmed-saber]

Please remember to update the version of the types as well

[josdejong]

Please remember to update the version of the types as well

I have no control over DefinitelyTyped/DefinitelyTyped#73377, we have to await until it is reviewed and merged. I guess you'll have to use @ts-ignore for the time being.