-
-
Notifications
You must be signed in to change notification settings - Fork 88
[small]Feature/773 #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[small]Feature/773 #777
Conversation
josdem
commented
Dec 2, 2025
- Adding find by email in a single search feature
- Adding missing tests
- Updating project version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds email-based user lookup to the existing flexible search functionality, extends test coverage for the new search chain, and bumps the project version. The getByUsername method is renamed to getUser to better reflect its expanded capability to search by username, mobile, or email in a single call.
Key Changes:
- Extended
getUsermethod to chain username → mobile → email lookups using Optional'sor()operator - Renamed method from
getByUsernametogetUseracross service interface, implementation, and controller - Added comprehensive test cases for mobile and email fallback scenarios
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/main/java/com/josdem/vetlog/service/UserService.java |
Renamed method from getByUsername to getUser in interface |
src/main/java/com/josdem/vetlog/service/impl/UserServiceImpl.java |
Added email lookup as third option in search chain and renamed method |
src/main/java/com/josdem/vetlog/controller/VetController.java |
Updated method call to use renamed getUser method |
src/test/java/com/josdem/vetlog/service/UserServiceTest.kt |
Added test cases for mobile and email fallback scenarios, updated existing tests |
build.gradle.kts |
Incremented version from 3.3.2 to 3.3.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/main/java/com/josdem/vetlog/service/impl/UserServiceImpl.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|


