Skip to content

Fix exception when DMCA'd starred gists are backed up#525

Open
mrexodia wants to merge 1 commit into
josegonzalez:masterfrom
mrexodia:gist-fix
Open

Fix exception when DMCA'd starred gists are backed up#525
mrexodia wants to merge 1 commit into
josegonzalez:masterfrom
mrexodia:gist-fix

Conversation

@mrexodia

Copy link
Copy Markdown
Contributor

No description provided.

@josegonzalez

Copy link
Copy Markdown
Owner

@Iamrodos thoughts on unit tests here?

@Iamrodos

Copy link
Copy Markdown
Contributor

@Iamrodos thoughts on unit tests here?

I wrote one yesterday but ended up abandoning the post.

  1. It was about ninety lines of testing for a one line code change. It was more about regression testing over efficacy.
  2. There is a rabbit hole I went down over removing the crash which starts masking failed runs. The earlier test of 128 fires for a DMCA but also for network error, throttle etc. I got lost trying to untangle that and if warnings should be present, because the clone is skipped but the metadata retrieved earlier is still saved.

Net outcome, the change is valid and a test is probably border line helpful. The nuances around failures get so convoluted with the shell command and error codes that it's probably best to wait for issues than over engineer (which is my typical tendency 😊 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants