fixes TSL to report the same state for all devices #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello there maklem 👋
Thank you for opening your first PR for the Tally Arbiter project!
We will review it soon!
TallyArbiter fosters an open and welcoming environment for all our contributors. Please adhere to our Code Of Conduct.
maklem
force-pushed
the
TA-765_TSL-reporting-the-same-for-all-devices
branch
from
697eb7e to
cefca02
Compare
|
resolved conflicts (autoclrf messing with line endings) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues
Changes
UpdateDeviceStatederivescurrentDeviceTallyDatafromSourceClientsinstead ofcurrentSourceTallyDataBackground
In
sourceClient.tally.subscribe(...)nearsrc/index.ts:1353tally data is prepared for a source.For every entry, that matches a device_source the tally data is stored per
sourceIddropping the address.If multiple entries match (i.e. for the test source), the last match overwrites any previous matches.
(which leads to odd behavior as described in #765 and #778)
I do not understand the intention of
currentSourceTallyDatafor sources referring to multiple addresses.I found
SourceClientsis used ingetDeviceStates()(nearindex.ts:1125) and concluded thatSourceClientscontains the needed information, and can be used.Testing