remove undeclared (unnecessary) require('mongodb') call in 0.6 branch #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizzao
changed the title
|
+1 thanks @mizzao ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 0.6 mongo driver does a
require("mongodb")even when aclientis passed in. Because thisrequireis undeclared, it caused issues with providing the right Mongo driver in settings like a Meteor app:meteor/meteor#532
mizzao/meteor-sharejs#22
I know this is old code, and it probably won't be reviewed. But I generally try to create pull requests for things I fix rather than hiding dangling commits everywhere. :)