Add a criterion bench for the distributed cache hot path#2283
Merged
christian-schilling merged 1 commit intoJul 20, 2026
Conversation
christian-schilling
force-pushed
the
@base/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
from
July 20, 2026 07:57
cd4a254 to
6dbb77b
Compare
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
from
July 20, 2026 07:57
529584d to
10548a2
Compare
christian-schilling
force-pushed
the
@base/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
from
July 20, 2026 08:29
6dbb77b to
dd692e2
Compare
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
from
July 20, 2026 08:29
10548a2 to
9b71d13
Compare
christian-schilling
changed the base branch from
@base/master/christian.schilling.de@gmail.com/bench-distributed-cache
to
master
July 20, 2026 08:29
christian-schilling
marked this pull request as ready for review
July 20, 2026 08:29
Merging this PR will not alter performance
Performance Changes
Comparing Footnotes |
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
from
July 20, 2026 10:24
9b71d13 to
2c7e42e
Compare
deephistory_subdir_distributed mirrors deephistory_subdir_sparse -- the same long, sparse-output history filtered by :/dir_00 -- but the cache stack under measurement carries a DistributedCacheBackend in addition to sled, matching the josh CLI default. The history is linear, so almost every input commit is ineligible for the sparse persisted cache. The distributed backend then does nothing per commit except run its eligibility check, which makes that check the dominant per-commit cost and the signal this bench isolates. Each timed iteration resets the sled cache and deletes refs/josh/cache/* so the distributed cache starts cold. Change: bench-distributed-cache Assisted-By: Claude Fable 5 (claude-fable-5)
christian-schilling
force-pushed
the
@changes/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
from
July 20, 2026 11:11
2c7e42e to
351e769
Compare
christian-schilling
enabled auto-merge
July 20, 2026 11:11
vlad-ivanov-name
approved these changes
Jul 20, 2026
christian-schilling
deleted the
@changes/master/christian.schilling.de@gmail.com/bench-distributed-cache
branch
July 20, 2026 11:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a criterion bench for the distributed cache hot path
deephistory_subdir_distributed mirrors deephistory_subdir_sparse -- the same long,
sparse-output history filtered by :/dir_00 -- but the cache stack under measurement carries a
DistributedCacheBackend in addition to sled, matching the josh CLI default.
The history is linear, so almost every input commit is ineligible for the sparse persisted
cache. The distributed backend then does nothing per commit except run its eligibility check,
which makes that check the dominant per-commit cost and the signal this bench isolates. Each
timed iteration resets the sled cache and deletes refs/josh/cache/* so the distributed cache
starts cold.
Change: bench-distributed-cache
Assisted-By: Claude Fable 5 (claude-fable-5)