feat(api): externalize deserialization#14
Merged
Merged
Conversation
joshdoman
changed the title
Transaction type
joshdoman
force-pushed
the
pre-deserialize
branch
from
6da6507 to
0a8fa0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR externalizes deserialization. This is appropriate because the consumer of the API may want to use the
Transactiontype in the request payload struct, so they can benefit from the built-in deserialization.Currently, doing so requires the consumer to needlessly serialize the transaction to use the library, just for the library to deserialize it again. Now, the library performs no deserializations, and only the
Verifiermay need to serialize the transaction, to pass it to the kernel.As deserialization is no longer necessary, the
DeserializationFailederror type has been removed.