[pre-push] Factor out commits_between into util

[joshlf]

---

• 　 [WIP] Pre-push hook pipeline architecture #267
• 　 [pre-push] Remove timing trace logging #266
• 👉 [pre-push] Factor out commits_between into util #265

Latest Update: v2 — Compare vs v1

📚 Full Patch History

Links show the diff between the row version and the column version.

Version	v1	Base
v2	vs v1	vs Base
v1		vs Base

[gemini-code-assist]

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the commit collection mechanism by centralizing the logic for identifying commits between two references into a dedicated utility function. This change improves code organization, reusability, and error handling within the repository operations, making the pre_push module cleaner and more focused on its primary task.

Highlights

• Refactoring Commit Collection Logic: The logic for collecting commits between HEAD and the default branch has been extracted from src/pre_push.rs and moved into a new utility function in src/util.rs.
• New commits_between Utility Method: A new method, commits_between, has been added to the Repo struct in src/util.rs. This method encapsulates the functionality to find all commits between a given ancestor and descendant ID, including an ancestry check.
• Improved Error Handling: A new CommitsBetweenError enum was introduced in src/util.rs to provide more specific error types for the commits_between function, differentiating between a 'NotAncestor' scenario and general eyre::Error.
• Removal of is_ancestor: The standalone is_ancestor method in src/util.rs has been removed, as its functionality is now integrated and handled within the new commits_between method.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that extracts the logic for finding commits between two references into a new utility function, commits_between, in src/util.rs. This improves code organization and modularity. The implementation is solid, but I have a couple of suggestions to enhance the readability and conciseness of the new function.