Skip to content

[pre-push] Fix markdown PR list alignment#276

Merged
joshlf merged 1 commit intomainfrom
Geb6d5a00c1076bf4c73d1703e80ef86d57f0a2a9
Jan 28, 2026
Merged

[pre-push] Fix markdown PR list alignment#276
joshlf merged 1 commit intomainfrom
Geb6d5a00c1076bf4c73d1703e80ef86d57f0a2a9

Conversation

@joshlf
Copy link
Owner

@joshlf joshlf commented Jan 28, 2026

Before PRs other than the current one, add the unicode "thin space"
character (U+2009), which results in these lines being aligned with the
current PR (which is prefixed with the 👉 emoji).

Closes #275


Latest Update: v3 — Compare vs v2

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v2 v1 Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base

Stacked PRs enabled by GHerrit.

@gemini-code-assist
Copy link

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual alignment issue in the markdown representation of pull request lists generated by the pre-push hook. By strategically inserting a thin space character, the change ensures that all listed pull requests, regardless of whether they are the currently active one, maintain a clean and consistent horizontal alignment, enhancing readability.

Highlights

  • Markdown List Alignment Fix: Introduced a fix to improve the alignment of pull request lists in markdown output by adding a Unicode 'thin space' character (U+2009) before PRs other than the current one.
  • Code Change in src/pre_push.rs: Modified the prefix logic within the sync_prs function to conditionally include   (thin space) for non-current PRs, ensuring consistent visual alignment with the active PR marked by the '👉' emoji.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a markdown alignment issue in the generated pull request list by adding a thin space character. The approach is valid for the target environment. I've provided one suggestion to use native Rust Unicode escape sequences instead of HTML entities, which improves code consistency and readability.

Before PRs other than the current one, add the unicode "thin space"
character (U+2009), which results in these lines being aligned with the
current PR (which is prefixed with the 👉 emoji).

Closes #275

gherrit-pr-id: Geb6d5a00c1076bf4c73d1703e80ef86d57f0a2a9
@joshlf joshlf force-pushed the Geb6d5a00c1076bf4c73d1703e80ef86d57f0a2a9 branch from faa1d6b to 4746290 Compare January 28, 2026 22:58
@joshlf joshlf merged commit 775c88f into main Jan 28, 2026
1 check passed
@joshlf joshlf deleted the Geb6d5a00c1076bf4c73d1703e80ef86d57f0a2a9 branch January 28, 2026 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR body PR navigation bulleted list: Fix spacing by using U+2009 on every line *other* than the current PR

1 participant