Skip to content

[pre-push] Add heuristic backoff for failing GraphQL requests#286

Merged
joshlf merged 1 commit intomainfrom
G9cbf0a128de86e6698dc89a907801938e3aa19f8
Feb 9, 2026
Merged

[pre-push] Add heuristic backoff for failing GraphQL requests#286
joshlf merged 1 commit intomainfrom
G9cbf0a128de86e6698dc89a907801938e3aa19f8

Conversation

@joshlf
Copy link
Owner

@joshlf joshlf commented Feb 9, 2026

We've seen in practice that large GraphQL requests cause confusing
errors. This commit adds heuristics to back off ahead of time before we
encounter these errors.

See also #287


Latest Update: v4 — Compare vs v3

📚 Full Patch History

Links show the diff between the row version and the column version.

Version v3 v2 v1 Base
v4 vs v3 vs v2 vs v1 vs Base
v3 vs v2 vs v1 vs Base
v2 vs v1 vs Base
v1 vs Base
⬇️ Download this PR

Branch

git fetch origin refs/heads/G9cbf0a128de86e6698dc89a907801938e3aa19f8 && git checkout -b pr-G9cbf0a128de86e6698dc89a907801938e3aa19f8 FETCH_HEAD

Checkout

git fetch origin refs/heads/G9cbf0a128de86e6698dc89a907801938e3aa19f8 && git checkout FETCH_HEAD

Cherry Pick

git fetch origin refs/heads/G9cbf0a128de86e6698dc89a907801938e3aa19f8 && git cherry-pick FETCH_HEAD

Pull

git pull origin refs/heads/G9cbf0a128de86e6698dc89a907801938e3aa19f8

Stacked PRs enabled by GHerrit.

@gemini-code-assist
Copy link

Summary of Changes

Hello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the observability of GraphQL requests by integrating detailed trace logging. This addition will significantly aid in debugging and understanding the precise queries being dispatched, particularly in intricate operational contexts.

Highlights

  • GraphQL Request Logging: Introduced log::trace! to output the full GraphQL query string and its length before sending the request, enhancing debugging capabilities for GraphQL interactions.
  • Variable Renaming: The variable query_body was renamed to request_payload for improved clarity and semantic accuracy.
Changelog
  • src/pre_push.rs
    • Renamed the local variable query_body to request_payload to better reflect its purpose.
    • Added a log::trace! statement to output the length and content of the GraphQL query string immediately before it is sent.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist
Copy link

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

We've seen in practice that large GraphQL requests cause confusing
errors. This commit adds heuristics to back off ahead of time before we
encounter these errors.

See also #287

gherrit-pr-id: G9cbf0a128de86e6698dc89a907801938e3aa19f8
@joshlf joshlf changed the title [pre-push] Add trace logging for GraphQL requets [pre-push] Add heuristic backoff for failing GraphQL requests Feb 9, 2026
@joshlf joshlf force-pushed the G9cbf0a128de86e6698dc89a907801938e3aa19f8 branch from be1b0c6 to 1b53d85 Compare February 9, 2026 17:10
@joshlf joshlf merged commit 34e0add into main Feb 9, 2026
1 check passed
@joshlf joshlf deleted the G9cbf0a128de86e6698dc89a907801938e3aa19f8 branch February 9, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant