Fixes for the PCB_MOUNT controller mount.#97
Open
mjonuschat wants to merge 4 commits into
Open
Conversation
Values were hardcoded in dactyl_manuform.py, move them to the config for customization.
Instead of ignoring the configuration and calculating it based on the configured TRRS Hole size and the PCB Holder position on the Z-axis. Updated the configuration so that the default values match the previously calculated values.
Configuration was ignored / overwritten with a hardcoded value inside of the trrs_hole() method.
Allow overriding the Z-axis offset of the USB hole instead of calculating it based on the size of the USB hole and the size of the height of the PCB holder. Useful when socketing controllers and the offset is not only related to the thickness of the PCB holder. Updated the configuration defaults to match the previously calculated value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of small fixes that should make using the PCB_MOUNT controller_mount_type less surprising: