Fix video flicker by using selective CSS transitions#2
Open
joshribakoff wants to merge 1 commit intomainfrom
Open
Fix video flicker by using selective CSS transitions#2joshribakoff wants to merge 1 commit intomainfrom
joshribakoff wants to merge 1 commit intomainfrom
Conversation
The animation was experiencing subtle flickering/dimming at step boundaries. Root cause: The clearState() function removes all CSS classes before applying new ones. With 'transition: all', backgrounds would visibly transition back to default (#0f3460) before the new state colors were applied. Fix: Change CSS transitions to only animate specific properties: - .array-cell: transition transform and box-shadow only (not background/border) - .pointer: transition opacity only - .message-display: remove transition entirely This allows background/border colors to change instantly while preserving smooth scale and glow animations. Also adds regression tests that verify templates don't use 'transition: all' on elements that have clearState() applied to them. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transition: allto specific properties onlyRoot Cause
The
clearState()function removes highlight classes, causing backgrounds to transition back to default before new state is applied.Test plan
transition: allin templates🤖 Generated with Claude Code