Skip to content

improve block parsing perf #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joshuadavidthomas wants to merge 1 commit into from
Closed

improve block parsing perf #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/djls-templates/src/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,16 @@ impl<'db> Parser<'db> {
});
};

let mut parts = content_ref.text(self.db).split_whitespace();
let content = content_ref.text(self.db);
let mut parts = content.split_ascii_whitespace();

let name_str = parts.next().ok_or(ParseError::EmptyTag)?;
let name = TagName::new(self.db, name_str.to_string());
let name = TagName::new(self.db, name_str.to_owned());

let bits = parts.map(|s| TagBit::new(self.db, s.to_string())).collect();
let mut bits = Vec::with_capacity(parts.clone().count());
for part in parts {
bits.push(TagBit::new(self.db, part.to_owned()));
}
let span = token.content_span_or_fallback(self.db);

Ok(Node::Tag { name, bits, span })
Expand Down