Popover focus behavior#13
Draft
joshuawootonn wants to merge 1 commit into
Draft
Conversation
This commit updates several dialog components to consistently use `initialFocus={() => null}`. This ensures that focus is not automatically set on dialog elements, providing a better user experience. Additionally, it adds a `package-lock.json` file, which was missing.
Co-authored-by: joshuawootonn <joshuawootonn@gmail.com>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable automatic focus on open for the welcome dialog.
The
Introcomponent (welcome popup) was missing theinitialFocus={() => null}prop on itsDialogContent, which is necessary to prevent the dialog from automatically focusing on an element when it opens. This aligns its behavior with other dialogs like changelog, privacy policy, and terms of service.