Fix Windows ARM build and add cross-platform PR checks#49
Merged
Conversation
Reproduces the publish workflow's Windows ARM steps with debug output to understand why rustup picks up a stale settings.toml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MSYS2 on ARM Windows reports x86_64 via uname, causing rustup to default to x86_64-pc-windows-gnu host which needs gcc (not available in CLANGARM64 env). Explicitly set the host triple. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
New rustup-init creates settings.toml before reading CLI args, causing --default-host conflict. Remove the dir first. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rustup-init bakes in x86_64-pc-windows-gnu on MSYS2 ARM. Install first, then switch default host and toolchain to aarch64-pc-windows-gnullvm. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
MSYS2 on ARM Windows reports x86_64 via uname, causing rustup-init to default to x86_64-pc-windows-gnu host which needs gcc (unavailable in CLANGARM64). After install, switch to aarch64-pc-windows-gnullvm. Also removes test-windows and test-windows-arm workflows (no longer needed). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Catches platform-specific build failures before merge instead of at release time. Includes the ARM host triple fix for CLANGARM64. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x86_64-pc-windows-gnuhost (needsgcc, unavailable in CLANGARM64). After install, override toaarch64-pc-windows-gnullvm.build-macos.yml— builds on macOS aarch64 + x86_64 on every PRbuild-windows.yml— builds on Windows x86_64 + ARM on every PRtest-windows.yml(superseded bybuild-windows.yml)These catch platform-specific build failures before merge instead of at release time.
Test plan
fix-windows-arm-buildbranch🤖 Generated with Claude Code