Skip to content

fix: typo in docs #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: typo in docs #375

wants to merge 1 commit into from

Conversation

mattrothenberg
Copy link

@mattrothenberg mattrothenberg commented May 11, 2020 •
edited
Loading

@jossmac

Description of changes:
Fixes a typo in the Using The Modal code example.

As per https://github.com/jossmac/react-images/blob/master/index.d.ts#L45, src is not a valid key for ViewType.

Type '{ src: string; }[]' is not assignable to type 'ViewType[]'.
  Property 'source' is missing in type '{ src: string; }' but required in type 'ViewType'.ts(2322)

Checks:

  • Please confirm yarn run lint ran successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mattrothenberg