fix: More accurate approximation the font size on Windows. - #247
Merged
Conversation
It's more accurate, but I can't guarantee it to be working perfectly. Though it does work way better than before!
Owner
|
To fix the failing CI jobs do this:
|
Contributor
Author
|
I can't really commit directly to this branch because of #250 It's very weird tbf |
josueBarretogit
approved these changes
Dec 8, 2025
josueBarretogit
left a comment
josueBarretogit
left a comment
Owner
There was a problem hiding this comment.
Looks good to me, dont pay attention to the other failing jobs xd
Contributor
Author
|
Looks good to me to. I don't think I can add anything else to this PR. And I don't think it's really possible to do more than what I did here tbf. Windows API is way too shitty |
josueBarretogit
merged commit Mar 22, 2026
959a021
into
josueBarretogit:develop
3 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I am as promised after more than a year to try to fix #26 . It's still not perfect, but it yields a way better result. It's more accurate because I actually use a more accurate pixel width and height, and I take into account every DPI. I swapped the match to a simple calculation.
Before
After