feat!: Remove web-only MapOptions.webControls and all WebControl classes #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josxha
reviewed
Nov 13, 2024
Owner
josxha
left a comment
josxha
left a comment
There was a problem hiding this comment.
Looking good so far!
There is no abition for the js interop code to be as complete as possible as it just increases the code that needs to be maintained. So we can remove
addControl()from/lib/src/platform/web/interop/map.dart- and
/lib/src/platform/web/interop/controls.dartall together
josxha
changed the title
Contributor
Author
|
Changes made |
josxha
approved these changes
Nov 13, 2024
Merge remote-tracking branch 'origin/HEAD' into feat/remove-web-only-map-controls
10 tasks
Owner
|
I need to make the android integration tests more reliable. 🥲 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes a task of #113