Skip to content

Conversation

@josxha
Copy link
Owner

@josxha josxha commented Nov 1, 2025

  • addImages(Map<String, bytes>)
  • addImageFromIconData()
  • addImageFromAssets()
  • aboveLayerId parameter
  • atIndex parameter
  • fix offline region check
  • remove manual release of NSObjects (causes crashes)

@josxha josxha added this to the v0.3.1 milestone Nov 1, 2025
Copilot AI review requested due to automatic review settings November 1, 2025 18:02
@github-project-automation github-project-automation bot moved this to Backlog in maplibre dev Nov 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses memory management and a critical bug fix in the iOS platform implementation:

  • Removes manual release() calls on FFI objects for automatic memory management
  • Fixes an inverted condition in getOfflineRegion that prevented finding the correct region

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/src/platform/ios/style_controller.dart Removes manual release() calls on NSString and style layer/source objects in various methods (addLayer, addSource, removeImage, removeLayer, removeSource)
lib/src/platform/ios/offline_manager.dart Fixes inverted logic from != to == when searching for offline region by ID

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.64%. Comparing base (05bfb44) to head (4f1011a).
⚠️ Report is 1 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josxha josxha changed the title fix: remove ios manual release feat: add image helper functions Nov 1, 2025
@josxha josxha moved this from Backlog to In Progress in maplibre dev Nov 1, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 1, 2025

Deploying flutter-maplibre with  Cloudflare Pages  Cloudflare Pages

Latest commit: d5ea03b
Status: ✅  Deploy successful!
Preview URL: https://627f9db1.flutter-maplibre.pages.dev
Branch Preview URL: https://fix-remove-ios-manual-releas.flutter-maplibre.pages.dev

View logs

@josxha josxha changed the title feat: add image helper functions feat: add image helper functions, aboveLayerId parameter Nov 1, 2025
@josxha josxha changed the title feat: add image helper functions, aboveLayerId parameter feat: add image helper functions, aboveLayerId, atIndex parameter Nov 1, 2025
Copilot AI review requested due to automatic review settings November 1, 2025 19:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings November 1, 2025 19:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@josxha josxha enabled auto-merge (squash) November 1, 2025 19:23
@josxha josxha merged commit 6cb793d into main Nov 1, 2025
14 of 16 checks passed
@josxha josxha deleted the fix/remove-ios-manual-release branch November 1, 2025 19:28
@github-project-automation github-project-automation bot moved this from In Progress to Done in maplibre dev Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants