-
-
Notifications
You must be signed in to change notification settings - Fork 22
feat: add image helper functions, aboveLayerId, atIndex parameter
#391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses memory management and a critical bug fix in the iOS platform implementation:
- Removes manual
release()calls on FFI objects for automatic memory management - Fixes an inverted condition in
getOfflineRegionthat prevented finding the correct region
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/src/platform/ios/style_controller.dart | Removes manual release() calls on NSString and style layer/source objects in various methods (addLayer, addSource, removeImage, removeLayer, removeSource) |
| lib/src/platform/ios/offline_manager.dart | Fixes inverted logic from != to == when searching for offline region by ID |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
Deploying flutter-maplibre with
|
| Latest commit: |
d5ea03b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://627f9db1.flutter-maplibre.pages.dev |
| Branch Preview URL: | https://fix-remove-ios-manual-releas.flutter-maplibre.pages.dev |
aboveLayerId parameter
aboveLayerId parameteraboveLayerId, atIndex parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.