Skip to content

Conversation

@josxha
Copy link
Owner

@josxha josxha commented Nov 2, 2025

  • remove unused piegeon methods
  • dispose() needs to be reevaluated

@josxha josxha added this to the v0.3.1 milestone Nov 2, 2025
Copilot AI review requested due to automatic review settings November 2, 2025 16:41
@github-project-automation github-project-automation bot moved this to Backlog in maplibre dev Nov 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes unused API methods from the MapLibre host API and updates iOS FFI bindings to use UIImage instead of NSImage. The changes streamline the API surface by removing layer manipulation methods and image loading functionality that were not being used.

Key Changes:

  • Removed dispose() method and multiple layer addition methods from the MapLibre host API
  • Changed FFI configuration from NSImage to UIImage and UIScreen for iOS compatibility
  • Updated iOS implementation to remove stub methods and debug print statements
  • Generated new FFI bindings for UIImage, UIScreen, and related UI classes

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
pigeons/pigeon.dart Removed unused API methods from MapLibreHostApi interface
maplibre_ios/pubspec.yaml Updated ffigen config to use UIImage/UIScreen instead of NSImage
maplibre_ios/lib/maplibre_ffi.dart.m Auto-generated FFI implementation updates with reordered trampolines
maplibre_ios/lib/maplibre_ffi.dart Auto-generated Dart FFI bindings for UIImage and UIScreen classes
maplibre_ios/ios/.../Pigeon.g.swift Removed Swift implementation for deleted API methods
maplibre_ios/ios/.../MapViewDelegate.swift Removed stub implementations and debug print statements
lib/src/platform/pigeon.g.dart Removed Dart client code for deleted API methods
lib/src/platform/ios/style_controller.dart Updated commented code to use UIImage instead of NSImage
lib/src/platform/ios/map_state.dart Removed dispose() call to deleted API method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cloudflare-workers-and-pages
Copy link

Deploying flutter-maplibre with  Cloudflare Pages  Cloudflare Pages

Latest commit: 025e8bd
Status: ✅  Deploy successful!
Preview URL: https://d78ebaf1.flutter-maplibre.pages.dev
Branch Preview URL: https://clean-up-ios.flutter-maplibre.pages.dev

View logs

@josxha josxha merged commit 66177de into main Nov 2, 2025
21 of 23 checks passed
@josxha josxha deleted the clean-up-ios branch November 2, 2025 16:51
@github-project-automation github-project-automation bot moved this from Backlog to Done in maplibre dev Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants