Skip to content

Conversation

@josxha
Copy link
Owner

@josxha josxha commented Nov 7, 2025

Tasks

  • jni / jnigen 0.15.0
  • use new jnigen config file
  • use single file output for jnigen
  • remove unused jnigen classes
  • objective_c 9
  • ffigen 20
  • use new ffigen config file

Superseeds PRs

@josxha josxha added this to the v0.3.2 milestone Nov 7, 2025
@github-project-automation github-project-automation bot moved this to Backlog in maplibre dev Nov 7, 2025
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 7, 2025

Deploying flutter-maplibre with  Cloudflare Pages  Cloudflare Pages

Latest commit: 77011d4
Status: ✅  Deploy successful!
Preview URL: https://66993a01.flutter-maplibre.pages.dev
Branch Preview URL: https://upgrade-packages.flutter-maplibre.pages.dev

View logs

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.60%. Comparing base (4a66ba1) to head (77011d4).
⚠️ Report is 1 commits behind head on main.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josxha josxha changed the title feat: upgrade packages feat: jnigen / jni 0.15, remove unused android classes form codegen Nov 8, 2025
@josxha josxha marked this pull request as ready for review November 8, 2025 00:45
Copilot AI review requested due to automatic review settings November 8, 2025 00:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates jni/jnigen to version 0.15.0 and removes unused Android classes from code generation, resulting in a cleaner and more maintainable codebase.

  • Updates jni and jnigen dependencies to version 0.15.0
  • Migrates to new jnigen configuration file format and single-file output
  • Removes unused auto-generated Android JNI bindings
  • Updates Android platform functions to use new jni 0.15 APIs

Reviewed Changes

Copilot reviewed 43 out of 227 changed files in this pull request and generated no comments.

Show a summary per file
File Description
maplibre/lib/src/platform/android/jni/org/maplibre/android/camera/CameraUpdate.dart Removed unused CameraUpdate JNI bindings
maplibre/lib/src/platform/android/jni/org/maplibre/android/camera/CameraPosition.dart Removed unused CameraPosition JNI bindings
maplibre/lib/src/platform/android/jni/org/maplibre/android/attribution/*.dart Removed unused attribution-related JNI bindings
maplibre/lib/src/platform/android/jni/org/maplibre/android/MapLibre.dart Removed unused MapLibre JNI bindings
maplibre/lib/src/platform/android/jni/java/net/*.dart Removed unused URL and URI JNI bindings
maplibre/lib/src/platform/android/jni/io/flutter/plugin/platform/*.dart Removed unused Flutter platform view JNI bindings
maplibre/lib/src/platform/android/jni/io/flutter/plugin/common/PluginRegistry.dart Removed unused plugin registry JNI bindings
maplibre/lib/src/platform/android/jni/com/github/josxha/maplibre/*.dart Removed unused custom FlutterApi JNI bindings
maplibre/lib/src/platform/android/jni.dart Removed exports for deleted JNI binding files
maplibre/lib/src/platform/android/functions.dart Updated to use new jni 0.15 APIs for Context and Activity retrieval

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@josxha josxha merged commit bacbbcb into main Nov 8, 2025
15 checks passed
@josxha josxha deleted the upgrade-packages branch November 8, 2025 00:48
@github-project-automation github-project-automation bot moved this from Backlog to Done in maplibre dev Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants