-
-
Notifications
You must be signed in to change notification settings - Fork 23
feat: update gradle dependencies, upgrade maplibre native android to 12.2.+
#413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update gradle dependencies, upgrade maplibre native android to 12.2.+
#413
Conversation
Deploying flutter-maplibre with
|
| Latest commit: |
d474f45
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af88dc40.flutter-maplibre.pages.dev |
| Branch Preview URL: | https://dependabot-gradle-example-an-cmll.flutter-maplibre.pages.dev |
18ee005 to
c7167e2
Compare
…updates Bumps the dependencies group with 1 update in the /example/android directory: org.jlleitschuh.gradle.ktlint. Bumps the dependencies group with 4 updates in the /maplibre/android directory: com.android.tools.build:gradle, org.jlleitschuh.gradle:ktlint-gradle, [org.maplibre.gl:android-sdk](https://github.com/maplibre/maplibre-native) and [io.nlopez.compose.rules:ktlint](https://github.com/mrmans0n/compose-rules). Updates `org.jlleitschuh.gradle.ktlint` from 13.1.+ to 14.0.1 Updates `com.android.tools.build:gradle` from 8.12.3 to 8.13.1 Updates `org.jlleitschuh.gradle:ktlint-gradle` from 13.1.+ to 14.0.1 Updates `org.maplibre.gl:android-sdk` from 12.0.+ to 12.1.3 - [Release notes](https://github.com/maplibre/maplibre-native/releases) - [Changelog](https://github.com/maplibre/maplibre-native/blob/main/CHANGELOG.md) - [Commits](https://github.com/maplibre/maplibre-native/commits/android-v12.1.3) Updates `io.nlopez.compose.rules:ktlint` from 0.4.27 to 0.4.28 - [Release notes](https://github.com/mrmans0n/compose-rules/releases) - [Commits](mrmans0n/compose-rules@v0.4.27...v0.4.28) --- updated-dependencies: - dependency-name: org.jlleitschuh.gradle.ktlint dependency-version: 14.0.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: dependencies - dependency-name: com.android.tools.build:gradle dependency-version: 8.13.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: org.jlleitschuh.gradle:ktlint-gradle dependency-version: 14.0.1 dependency-type: direct:production update-type: version-update:semver-major dependency-group: dependencies - dependency-name: org.maplibre.gl:android-sdk dependency-version: 12.1.3 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: dependencies - dependency-name: io.nlopez.compose.rules:ktlint dependency-version: 0.4.28 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]>
c7167e2 to
b111b1c
Compare
12.2.+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates multiple Gradle dependencies for the Android platform, with the primary goal of upgrading MapLibre Native Android SDK from 12.0.+ to 12.2.+. The update brings new features and bug fixes from MapLibre Native, including MLT-format vector tile source support and various stability improvements. However, there is a critical issue with an invalid version for the compose rules dependency.
Key Changes:
- Upgrade MapLibre Native Android SDK to
12.2.+ - Update ktlint tooling from
13.1.+to14.0.+across both example and library projects - Update Android Gradle Plugin to
8.13.1 - Auto-generated JNI bindings updated to reflect new MapLibre SDK methods
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| maplibre/lib/src/platform/android/jni.g.dart | Auto-generated JNI bindings updated with new setFrustumOffset method from MapLibre SDK 12.2 |
| maplibre/android/build.gradle | Updated Android Gradle Plugin (8.13.1), ktlint-gradle (14.0.+), MapLibre SDK (12.2.+), and compose rules dependency (contains invalid version) |
| maplibre/CHANGELOG.md | Documents the MapLibre Native upgrade to version 12.2 |
| example/android/settings.gradle.kts | Updated ktlint plugin to 14.0.+ to align with library project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dependencies { | ||
| // jnigen picks up api dependencies | ||
| api 'org.maplibre.gl:android-sdk:12.0.+' | ||
| api 'org.maplibre.gl:android-sdk:12.2.+' |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a discrepancy between the PR description and the actual code changes. The PR description states that org.maplibre.gl:android-sdk was updated from 12.0.+ to 12.1.3, but the actual code shows it's being updated to 12.2.+ (which matches the PR title).
The dynamic version pattern 12.2.+ will resolve to the latest 12.2.x version available (e.g., 12.2.0, 12.2.1, etc.), which is the correct approach here. However, the PR description should be updated to reflect the actual version pattern being used.
| dependencies { | ||
| // jnigen picks up api dependencies | ||
| api 'org.maplibre.gl:android-sdk:12.0.+' | ||
| api 'org.maplibre.gl:android-sdk:12.2.+' |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a dynamic dependency version org.maplibre.gl:android-sdk:12.2.+ is a supply-chain risk and a security misconfiguration. An attacker compromising a future 12.2.x release or a malicious artifact in the repository could be pulled into production builds without code changes, leading to unintended behavior or compromise. Pin the dependency to an exact, vetted version (e.g., 12.2.3) or use a strict version constraint and lockfile to ensure reproducible builds.
| api 'org.maplibre.gl:android-sdk:12.2.+' | |
| api 'org.maplibre.gl:android-sdk:12.2.3' |
| classpath("org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version") | ||
| // noinspection GradleDynamicVersion | ||
| classpath("org.jlleitschuh.gradle:ktlint-gradle:13.1.+") | ||
| classpath("org.jlleitschuh.gradle:ktlint-gradle:14.0.+") |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a dynamic plugin version org.jlleitschuh.gradle:ktlint-gradle:14.0.+ is a supply-chain risk and a security misconfiguration. A compromised or buggy future 14.0.x release could be automatically consumed during builds, potentially executing malicious code in the CI/build environment. Pin to an exact version (e.g., 14.0.1) and use dependency locking to ensure reproducible and secure builds.
| id("com.android.application") version "8.12.0" apply false | ||
| id("org.jetbrains.kotlin.android") version "2.1.21" apply false | ||
| id("org.jlleitschuh.gradle.ktlint") version "13.1.+" apply false | ||
| id("org.jlleitschuh.gradle.ktlint") version "14.0.+" apply false |
Copilot
AI
Dec 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a dynamic plugin version org.jlleitschuh.gradle.ktlint:14.0.+ is a supply-chain risk and security misconfiguration. A compromised or unstable future 14.0.x release could be pulled into builds, potentially executing malicious code or breaking CI. Pin to an exact version (e.g., 14.0.1) and enable dependency locking to ensure reproducible, secure builds.
| id("org.jlleitschuh.gradle.ktlint") version "14.0.+" apply false | |
| id("org.jlleitschuh.gradle.ktlint") version "14.0.1" apply false |
Bumps the dependencies group with 1 update in the /example/android directory: org.jlleitschuh.gradle.ktlint.
Bumps the dependencies group with 4 updates in the /maplibre/android directory: com.android.tools.build:gradle, org.jlleitschuh.gradle:ktlint-gradle, org.maplibre.gl:android-sdk and io.nlopez.compose.rules:ktlint.
Updates
org.jlleitschuh.gradle.ktlintfrom 13.1.+ to 14.0.1Updates
com.android.tools.build:gradlefrom 8.12.3 to 8.13.1Updates
org.jlleitschuh.gradle:ktlint-gradlefrom 13.1.+ to 14.0.1Updates
org.maplibre.gl:android-sdkfrom 12.0.+ to 12.1.3Release notes
Sourced from org.maplibre.gl:android-sdk's releases.
Commits
Updates
io.nlopez.compose.rules:ktlintfrom 0.4.27 to 0.4.28Release notes
Sourced from io.nlopez.compose.rules:ktlint's releases.
Commits
c441f93Revert "Update plugin shadowJar to v9.2.2 (#498)"de73910Bump version to 0.4.281e49d7fUpdate plugin shadowJar to v9.2.2 (#498)93303caUpdate ktlint to 1.8.0 (#529)f4f433aUpdate plugin mavenPublish to v0.35.0 (#521)88bc2b7Update ktlint to 1.8.0 (#526)a887c22Update actions/checkout action to v6 (#528)990d6afUpdate Gradle to v9.2.1 (#525)70dc634Update plugin spotless to v8.1.0 (#527)95e02deUpdate dependency com.charleskorn.kaml:kaml to v0.102.0 (#516)Most Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions