Sourcery refactored master branch #1

sourcery-ai · 2023-05-04T22:41:13Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-05-04T22:41:15Z

getSecret.py

-            secret = get_secret_value_response["SecretString"]
-            return secret
+            return get_secret_value_response["SecretString"]
        else:
-            decoded_binary_secret = base64.b64decode(
-                get_secret_value_response["SecretBinary"]
-            )
-            return decoded_binary_secret
+            return base64.b64decode(get_secret_value_response["SecretBinary"])


Function get_secret refactored with the following changes:

Inline variable that is immediately returned [×2] (inline-immediately-returned-variable)

sourcery-ai · 2023-05-04T22:41:16Z

blue_green/python/get_launch_template.py


    for x in insts:
-        with open(x[0] + ".json", "w") as write_file:
+        with open(f"{x[0]}.json", "w") as write_file:


Lines 17-17 refactored with the following changes:

Use f-string instead of string concatenation (use-fstring-for-concatenation)

sourcery-ai · 2023-05-04T22:41:16Z

blue_green/python/kill_all_not_in_vpc.py

                    f"Failed to Remove {policy_arn} from Profile {role.name} - skipping ",
                    e,
                )
-                pass


Function delete_items refactored with the following changes:

Remove redundant pass statement [×3] (remove-redundant-pass)

sourcery-ai · 2023-05-04T22:41:16Z

blue_green/python/kill_all_vpc.py

                print(
                    f"SG {sec_group['GroupName']} {sec_group['GroupId']} does not have a group dependancy"
                )
-                pass


Function vpc_delete refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai · 2023-05-04T22:41:16Z

blue_green/python/list_vpcs_session.py

-            else:
-                pass


Function main refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai · 2023-05-04T22:41:17Z