Skip to content

Update bilingual_localization.js #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bluelovers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update bilingual_localization.js #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
327cbf7
Update bilingual_localization.js
bluelovers May 6, 2024
c94319a
Update bilingual_localization.js
bluelovers May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions javascript/bilingual_localization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,25 @@
[source, translation] = [translation, source]
}

const isTranslationIncludeSource = translation.startsWith(source);

switch (type) {
case 'text':
el.textContent = translation
break;

case 'element':
const htmlStr = `<div class="bilingual__trans_wrapper">${htmlEncode(translation)}<em>${htmlEncode(source)}</em></div>`
const htmlEl = parseHtmlStringToElement(htmlStr)

if (isTranslationIncludeSource) {
if (el.nodeType === 3) {
el.nodeValue = translation;
} else if (htmlEncode(el.textContent) === el.innerHTML) {
el.innerHTML = htmlEncode(translation)
}
break;
}

const htmlEl = parseHtmlStringToElement(`<div class="bilingual__trans_wrapper">${htmlEncode(translation)}<em>${htmlEncode(source)}</em></div>`)
if (el.hasChildNodes()) {
const textNode = Array.from(el.childNodes).find(node =>
node.nodeName === '#text' &&
Expand All @@ -324,15 +335,15 @@
break;

case 'option':
el.textContent = `${translation} (${source})`
el.textContent = isTranslationIncludeSource ? translation : `${translation} (${source})`
break;

case 'title':
el.title = `${translation}\n${source}`
el.title = isTranslationIncludeSource ? translation : `${translation}\n${source}`
break;

case 'placeholder':
el.placeholder = `${translation}\n\n${source}`
el.placeholder = isTranslationIncludeSource ? translation : `${translation}\n\n${source}`
break;

default:
Expand Down