[PoC]Added very basic support of theme Pause/Resume music and Music name #57, #63 - #78
[PoC]Added very basic support of theme Pause/Resume music and Music name #57, #63#78ashpynov wants to merge 54 commits into
Conversation
…ur of PlayniteSDK.Data API
9cc9cbe to
0d3f687
Compare
|
Hey @ashpynov! Sorry for letting this PR linger for so long. The plans I had for developing this plugin were interrupted by a lot of unexpected road blocks. As you might have noticed, I work out of a fork (https://github.com/cnapolit/PlayniteSound) that I merge into this repo once I'm ready for the next release. This fork is drastically different than the current state of this repo, with even more changes I have yet to commit. Thus, there would be some stellar conflicts that will be easier to handle via a fresh branch. With that in mind, I'll try and finalize all the changes I have locally and let you know once it's complete. I will still look through this PR and drop a comment here and there. If at any point you want to chat more directly, feel free to message me over discord. |
| Value="{StaticResource False}"> | ||
| <Setter | ||
| Property="Tag" | ||
| Value="{Binding ElementName=ExtraMetadataLoader_VideoLoaderControl_NoControls_Sound, Path=Content.SettingsModel.Settings.IsVideoPlaying}" |
There was a problem hiding this comment.
Judging from this line and the use of SettingsModel, Content is the plugin object itself.
However, it's not clear how the plugin is being injected. My best guess would be Playnite itself.
Lines 117 & 126 throw me off a little, since I don't see a IsPlayerMuted property in any of the changes in this PR.
Is this readme up to date?
There was a problem hiding this comment.
Well this part is outdated a little but as soon as now Mod injectect itself handling MediaElement.MediaOpenedEvent https://github.com/ashpynov/PlayniteSound/blob/66033f8eb7b41e590526c7bd6ace5f2f4e62fb34/PlayniteSounds.cs#L167 and https://github.com/ashpynov/PlayniteSound/blob/66033f8eb7b41e590526c7bd6ace5f2f4e62fb34/MediaElementsMonitor.cs#L47
Afrer it enumerate existing MediaElements with audio/video and pool their status.
So it no more actual to manually control extension from theme size but Mute music control via Tag remains
There was a problem hiding this comment.
Instead of a replacer, we could have a settings option to toggle between the two in case one or the other has issues.
There was a problem hiding this comment.
Only in case if it will load on runtime. Cause now it prevent loading of extension at all.
ashpynov
changed the title
Please consider this PR as Proof-Of-Concept. I will support this functionality in my modded version till you will complete your part of work. Then I will try reimplement approved/confirmed ideas on new codebase. |
Remove `ogg` and add compatible formats according to [this page](https://support.microsoft.com/en-us/topic/file-types-supported-by-windows-media-player-32d9998e-dc8f-af54-7ba1-e996f74375d9) (yes, `mid` files work :-D)
Add supported audio formats
[BUG] Sound playing on startup #15
…tall it using DISM tool.
- Proper pausing of background music #39 - Preloading of next music of fadeout phase to improve smoothness of transition - Configurable Media Player or SDL Mixer for playback
Added setup instructions for Python and ffmpeg-normalize.
…d to avoid DMCA strikes
4 participants
Please Here a PR to implement on 'old' version of extension abilty to integrate with theme to Pause/Resume music and expose current music name.
As soon as there is new extension major version development - I done modification to be as small as possible.
Information how to use it in theme added to readme.