Fixes #660: Improve typing/logic for options in decode, decode_complete; Improve docs
#1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pachewise
changed the title
optionsoptions in decode, decode_complete
pachewise
commented
Mar 3, 2025
auvipy
reviewed
Mar 4, 2025
|
@auvipy this should be ready to review. Note that I changed the documentation to use docstrings/autodoc so that the docs don't get stale (I saw a few cases where that happened). Also added more docs where needed; let me know if you'd rather me separate that into another PR. I still need an answer on whether we want to support the |
pachewise
commented
Mar 4, 2025
pachewise
changed the title
options in decode, decode_complete options in decode, decode_complete; Improve docs
auvipy
requested changes
Mar 5, 2025
auvipy
approved these changes
Mar 5, 2025
ryantqiu
pushed a commit
to snorkel-marlin-repos/jpadilla_pyjwt_pr_1045_453604b5-e4bf-4547-a21d-54a8ff772438
that referenced
this pull request
Oct 2, 2025
…lete; Improve docs Original PR #1045 by pachewise Original: jpadilla/pyjwt#1045
ryantqiu
added a commit
to snorkel-marlin-repos/jpadilla_pyjwt_pr_1045_453604b5-e4bf-4547-a21d-54a8ff772438
that referenced
this pull request
Oct 2, 2025
… in decode, decode_complete; Improve docs Merged from original PR #1045 Original: jpadilla/pyjwt#1045
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically trying to remove "Unknown" or "partially unknown" pylance issues. Mostly with
options, but there were a few simple other fixes (kwargs, segments, etc). This showed some minor bugs and a few code smells (passing too many args toapi_jws.decode_complete, for example).PyJWT()is used as a singleton. Do we want to keep theoptionsparam in that case? Wondering because codecov is warning that we don't have a test foroptions is not Nonecase.