fix that match_kid allways return None #1094
Open
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello ! I worked with auth using jwk client. I ran get_signing_key_from_jwt method to check token. I faced with error jwt.exceptions.PyJWKClientError: Unable to find a signing key that matches: "1399593380". I checked api from where i got jwks.json. And this kid was there. i began debugging process. As result i found that match_kid method return None every time. After a short time and several prints i found that key_id was int, but in type hints was string. The problem was that python couldn't compare sting and int correctly. I fix it using type conversion to string. And it works ! And i fix type hint for kid_id, too. I got it php service and library for jwt. As i understood kid could be as string as int, depending on implementation for different languages and libraries. Thanks
here is example of my keys