Thoroughly test type annotations, and resolve errors #1112
+76
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type checking across all supported Pythons revealed errors: * Python 3.9 doesn't have `typing.TypeAlias`. This is fixed by importing `typing_extensions.TypeAlias`. * Python 3.9 doesn't support type alias `x | y` union syntax. This is fixed by using `Union[x, y]` syntax. * Setting `warn-return-any = true` revealed that when `cryptography` isn't installed, `RSAPrivateKey.sign()` has an unknown signature. The return type cannot be `cast()` because it's redundant if `cryptography` is installed. This is fixed by adding `signature: bytes = key.sign()` and then returning `signature`. * All disabled error codes have been removed. * The pre-commit hook for mypy has been removed. It's less robust than running the test suite. * All functions and methods are now fully type-annotated.
auvipy
requested review from
auvipy and
Copilot
and removed request for
auvipy
There was a problem hiding this comment.
Pull Request Overview
This PR improves type checking infrastructure by removing the mypy pre-commit hook, adding tox-based mypy testing across all supported Python versions (3.9-3.14), and increasing mypy strictness. The changes enable type annotations to be tested in both crypto and nocrypto configurations across all Python versions.
- Added tox environments for running mypy on Python 3.9-3.14 with optional crypto extras
- Increased mypy strictness by enabling
strict = trueandwarn_return_any = true - Replaced Python 3.10+ union syntax with
Union[]for Python 3.9 compatibility
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Added mypy test environments for all Python versions (3.9-3.14) and a labeled group for running them |
| pyproject.toml | Enabled strict mypy checking and simplified configuration |
| jwt/jwks_client.py | Updated type ignore comment to be more specific |
| jwt/api_jwt.py | Added Python 3.9 support for TypeAlias, replaced union syntax, added cast for type safety |
| jwt/algorithms.py | Added Python 3.9 support for TypeAlias, replaced union syntax, added type annotations and return type hints |
| CHANGELOG.rst | Documented the development changes |
| .pre-commit-config.yaml | Removed mypy pre-commit hook |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
auvipy
requested changes
Oct 29, 2025
|
Just did. Copilot was wrong on all counts, and no changes are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type checking across all supported Pythons revealed errors:
Python 3.9 doesn't have
typing.TypeAlias.This is fixed by importing
typing_extensions.TypeAlias.Python 3.9 doesn't support type alias
x | yunion syntax.This is fixed by using
Union[x, y]syntax.Setting
warn-return-any = truerevealed that whencryptographyisn't installed,RSAPrivateKey.sign()has an unknown signature. The return type cannot becast()because it's redundant ifcryptographyis installed.This is fixed by adding
signature: bytes = key.sign()and then returningsignature.All disabled error codes have been removed.
The pre-commit hook for mypy has been removed. It's less robust than running the test suite.
All functions and methods are now fully type-annotated.